Do not generate type-indecisive expressions in unnecessary_cast
#14492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, if they appear within the context of a function argument, they will be marked as certain, as they might eventually be considered `i32` by default if the context is not more specific. Also, in the case of binary expressions, if one of the side is uncertain, then the certainty will come from the other side.
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
|
The lintcheck run contains new false negatives though. |
samueltardieu
force-pushed
the
push-omoqnppxvzpv
branch
2 times, most recently
from
7f627a4 to
95968ac
Compare
Associated constants of primitive types are resolved as `Res::Err` in the HIR. To force a resolution, the primitive type must be recognized as certain. Since they are not ADT, they don't have a `DefId`. By allowing the `Certainty` type to embed a `TypeKind` which is either a `PrimTy` or a `DefId`, we allow primitives types to be resolved, and the associated constants as well. Also, in method calls, if the receiver is not certain, consider that the overall call is not either.
samueltardieu
force-pushed
the
push-omoqnppxvzpv
branch
from
95968ac to
8ad3b0f
Compare
samueltardieu
added
S-waiting-on-author
|
☔ The latest upstream changes (possibly ff307ba) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires fixing the type certainty evaluation:
This might be to be refined further, but this does not break any existing test, and allows for new fixes such as this one.
Fix #14366
changelog: [
unnecessary_cast]: do not remove casts if the expression would become type-indecisive